Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync Quaternion with the version in Godot #1630

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Sync Quaternion with the version in Godot #1630

merged 1 commit into from
Oct 29, 2024

Conversation

dsnopek
Copy link
Collaborator

@dsnopek dsnopek commented Oct 28, 2024

Fixes #1629

I basically just copied Godot's quaternion.h/.cpp over godot-cpp's, then undid changes where the differences were necessary.

@dsnopek dsnopek added the enhancement This is an enhancement on the current functionality label Oct 28, 2024
@dsnopek dsnopek added this to the 4.x milestone Oct 28, 2024
@dsnopek dsnopek requested a review from a team as a code owner October 28, 2024 20:39
@dsnopek dsnopek requested a review from fire October 28, 2024 20:39
@dsnopek dsnopek mentioned this pull request Oct 28, 2024
Closed
fire
fire approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resolves the issue because Vector3 Quaternion::get_euler(EulerOrder p_order) const is supplied so that people can decide to use the right euler with the right rotation type (of 6)

@dsnopek dsnopek merged commit dfdc047 into godotengine:master Oct 29, 2024
12 checks passed
@dsnopek dsnopek mentioned this pull request Nov 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips approved these changes

@fire fire fire approved these changes

Assignees
No one assigned
Labels
cherrypick:4.2 cherrypick:4.3 enhancement This is an enhancement on the current functionality
Projects
None yet
Milestone
4.x
Development

Successfully merging this pull request may close these issues.

Wrong function conversion from Euler to Quaternion
3 participants
@dsnopek @fire @AThousandShips